Only limit the neighbor cache rate after sending a request packet #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, the neighbor cache would get limited even when the device failed to process our arp packet, which could put the socket in the waiting state in the next poll. This change only limits the cache rate if the device successfully consumed our packet.
|
The change seems fine as-is, but I think that the |
|
Makes sense, I will try something. |
|
Ok, done. Let me know what you think of my approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, the neighbor cache rate would get limited even when the device failed to process our arp packet, which could put the socket in the waiting state in the next poll.
This change only limits the cache rate if the device successfully consumed our packet.
Closes #319
againFor more information refer to my comment on the issue.